xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH] x86 emulation: suppress rep prefix handling on non-r

from [Jan Beulich]

[Permanent Link][Original]

To:	<xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	[Xen-devel] [PATCH] x86 emulation: suppress rep prefix handling on non-repeatable instructions
From:	"Jan Beulich" <jbeulich@xxxxxxxxxx>
Date:	Thu, 15 Feb 2007 09:58:46 +0000
Delivery-date:	Thu, 15 Feb 2007 01:57:32 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

Otherwise, pause or the recommended one-byte ret workaround on AMD
processors may have ill side effects.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

Index: 2007-02-07/xen/arch/x86/x86_emulate.c
===================================================================
--- 2007-02-07.orig/xen/arch/x86/x86_emulate.c  2007-02-08 08:46:39.000000000 
+0100
+++ 2007-02-07/xen/arch/x86/x86_emulate.c       2007-02-08 09:32:00.000000000 
+0100
@@ -1579,7 +1579,9 @@ x86_emulate(
     if ( twobyte )
         goto twobyte_special_insn;
 
-    if ( rep_prefix )
+    if ( rep_prefix &&
+         (((b & ~0xf) == 0xa0 && ((0xfcf0 >> (b & 0xf)) & 1)) ||
+          (b & ~3) == 0x6c) )
     {
         if ( _regs.ecx == 0 )
         {


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] x86 emulation: suppress rep prefix handling on non-repeatable instructions, Jan Beulich <=

Previous by Date:	[Xen-devel] [PATCH] x86/PAE partially linear page table support, Jan Beulich
Next by Date:	[Xen-devel] [PATCH] x86 emulation: fix bswap, Jan Beulich
Previous by Thread:	[Xen-devel] [PATCH] x86/PAE partially linear page table support, Jan Beulich
Next by Thread:	[Xen-devel] [PATCH] x86 emulation: fix bswap, Jan Beulich
Indexes:	[Date] [Thread] [Top] [All Lists]