WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] If we're building debug, show more guestinformat

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>, <john.levon@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] If we're building debug, show more guestinformation
From: "Ian Pratt" <m+Ian.Pratt@xxxxxxxxxxxx>
Date: Fri, 9 Feb 2007 17:30:40 -0000
Delivery-date: Fri, 09 Feb 2007 09:30:48 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C1F24F77.88DA%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcdMZgNaQhRTIrhZEduznwANk04WTAACfKtA
Thread-topic: [Xen-devel] [PATCH] If we're building debug, show more guestinformation
> It's really not that hard to add loglvl=all guest_loglvl=all (or
similar)
> to your boot command line when you want it (e.g., dev&test
environments).

I agree with John that changing the default is handy.

Ian

 
>  K.
> 
> On 9/2/07 2:04 pm, "john.levon@xxxxxxx" <john.levon@xxxxxxx> wrote:
> 
> > # HG changeset patch
> > # User john.levon@xxxxxxx
> > # Date 1171033428 28800
> > # Node ID 4708ec13626af36ce5440daa627149cb35e68fd2
> > # Parent  e26e9fcc0e6e4cc0e8a3330611be984c17985743
> > If we're building debug, show more guest information.
> >
> > Signed-off-by: John Levon <john.levon@xxxxxxx>
> >
> > diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
> > --- a/xen/drivers/char/console.c
> > +++ b/xen/drivers/char/console.c
> > @@ -67,14 +67,18 @@ static DEFINE_SPINLOCK(console_lock);
> >   *
> >   * L < lower_threshold                     : always logged
> >   * lower_threshold <= L < upper_threshold  : rate-limited logging
> > - * upper_threshold <= L                    : never logged
> > + * upper_threshold < L                    : never logged
> >   *
> >   * Note, in the above algorithm, to disable rate limiting simply
make
> >   * the lower threshold equal to the upper.
> >   */
> >  #define XENLOG_UPPER_THRESHOLD       2 /* Do not print INFO and
DEBUG
> */
> >  #define XENLOG_LOWER_THRESHOLD       2 /* Always print ERR and
WARNING
> */
> > +#ifdef NDEBUG
> >  #define XENLOG_GUEST_UPPER_THRESHOLD 2 /* Do not print INFO and
DEBUG
> */
> > +#else
> > +#define XENLOG_GUEST_UPPER_THRESHOLD 3 /* Do not print DEBUG */
> > +#endif
> >  #define XENLOG_GUEST_LOWER_THRESHOLD 0 /* Rate-limit ERR and
WARNING
> */
> >  /*
> >   * The XENLOG_DEFAULT is the default given to printks that
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@xxxxxxxxxxxxxxxxxxx
> > http://lists.xensource.com/xen-devel
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>