WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] behavioral change due to new elf code

To: Jan Beulich <jbeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] behavioral change due to new elf code
From: Gerd Hoffmann <kraxel@xxxxxxx>
Date: Fri, 09 Feb 2007 14:17:36 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 09 Feb 2007 05:17:08 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <45CC7EC1.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <45CC7EC1.76E4.0078.0@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 1.5.0.9 (X11/20060911)
Jan Beulich wrote:
> Is it intentional that with the new ELF code notes unknown to the hypervisor
> lead to dom0 being unbootable? The old code simply queried for those notes
> mattering at all for dom0, but din't care about any others...

No.

-- 
Gerd Hoffmann <kraxel@xxxxxxx>
--- xen/common/libelf/libelf-dominfo.c~ 2007-02-08 09:39:33.000000000 +0100
+++ xen/common/libelf/libelf-dominfo.c  2007-02-09 14:14:58.000000000 +0100
@@ -107,9 +107,9 @@
     if ((type >= sizeof(note_desc) / sizeof(note_desc[0])) ||
        (NULL == note_desc[type].name))
     {
-       elf_err(elf, "%s: unknown xen elf note (0x%x)\n",
+       elf_msg(elf, "%s: unknown xen elf note (0x%x)\n",
                __FUNCTION__, type);
-       return -1;
+       return 0;
     }
 
     if (note_desc[type].str)
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel