Re: [Xen-devel] [PATCH][SVM] Remove redundant update to V_TPR register

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

No, vlapic_set_reg() only writes to the software field. It doesn't call out
to update_vtpr().

 -- Keir

On 1/2/07 03:09, "Travis Betak" <travis.betak@xxxxxxx> wrote:

> This patch removes the redundant update to the V_TPR VMCB field.  The
> update is already done in the preceding call to vlapic_set_reg.
> 
> This fix is for changeset 13762 in xen-unstable.hg
> 
> Please apply.
> 
> Signed-off-by: Travis Betak <travis.betak@xxxxxxx>
> 
> ---
> 
> diff -r 588dd80b56b5 xen/arch/x86/hvm/svm/svm.c
> --- a/xen/arch/x86/hvm/svm/svm.c Wed Jan 31 19:37:44 2007 +0000
> +++ b/xen/arch/x86/hvm/svm/svm.c Wed Jan 31 20:59:02 2007 -0600
> @@ -1948,7 +1948,6 @@ static int mov_to_cr(int gpreg, int cr,
> 
>       case 8:
>           vlapic_set_reg(vlapic, APIC_TASKPRI, ((value & 0x0F) << 4));
> -        vmcb->vintr.fields.tpr = value & 0x0F;
>           break;
> 
>       default:
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel