WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [Xen-staging] [xen-unstable] ia64, ppc: Remove uses of s

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] Re: [Xen-staging] [xen-unstable] ia64, ppc: Remove uses of sprintf().
From: Alex Williamson <alex.williamson@xxxxxx>
Date: Tue, 30 Jan 2007 10:03:02 -0700
Cc: Christoph Egger <Christoph.Egger@xxxxxxx>
Delivery-date: Tue, 30 Jan 2007 09:02:45 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200701301614.l0UGEJgQ026181@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: HP OSLO R&D
References: <200701301614.l0UGEJgQ026181@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Tue, 2007-01-30 at 16:14 +0000, Xen staging patchbot-unstable wrote:
> diff -r 300c47bec138 -r bd69e83b65ea xen/arch/ia64/linux-xen/setup.c
> --- a/xen/arch/ia64/linux-xen/setup.c Tue Jan 30 16:09:16 2007 +0000
> +++ b/xen/arch/ia64/linux-xen/setup.c Tue Jan 30 16:14:16 2007 +0000
> @@ -550,7 +550,7 @@ show_cpuinfo (struct seq_file *m, void *
>       switch (c->family) {
>             case 0x07:        memcpy(family, "Itanium", 8); break;
>             case 0x1f:        memcpy(family, "Itanium 2", 10); break;
> -           default:          sprintf(family, "%u", c->family); break;
> +           default:          snprintf(family, sizeof(family), "%u", 
> c->family); break;
>       }

   What's the purpose of all this "cleanup"?  This is just munging files
that we're leveraging from Linux, making updating them later on more
difficult.  And these really should have been submitted via the
xen-ia64-devel list.

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>