WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Fix softlockup issue after vcpu hotplug

To: "Tian, Kevin" <kevin.tian@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix softlockup issue after vcpu hotplug
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 30 Jan 2007 12:57:05 +0000
Delivery-date: Tue, 30 Jan 2007 04:56:48 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <D470B4E54465E3469E2ABBC5AFAC390F9E1182@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcdESFqDCWsISfq5RGeHgxcxVzRqmQACelaDAAAZiDAAAP4q2wADxf1QAAFVV3AAAMUYXA==
Thread-topic: [Xen-devel] [PATCH] Fix softlockup issue after vcpu hotplug
User-agent: Microsoft-Entourage/11.3.3.061214
On 30/1/07 12:45 pm, "Tian, Kevin" <kevin.tian@xxxxxxxxx> wrote:

> Actually I'm a bit interested in this case, where watchdog thread
> depends on timer interrupt to be awaken, while next timer interval
> depends on soft timer wheel. For the new online cpu, all its
> processes previously running have been migrated to others before
> offline. Thus when just coming back online, there may be no
> meaningful timer wheel and few activities on that vcpu. In this case,
> a (LONG_MAX >> 1) may be returned as a big timeout.

Yeah, but the thread should get migrated back again (or recreated) in fairly
short order. I think we can agree it should take rather less than 10
seconds. :-)

> So saying this new watchdog model, simply walking timer wheel is
> not enough. Maybe we can force max timeout value to 1s in safe_halt
> to special this case? I'll make a try on this. But this will make current
> tick-less model to a bit tick-ful back. :-)

I'm sure this will fix the issue. But who knows what real underlying issue
it might be hiding?

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel