Re: [Xen-devel] [PATCH][RFC] correction trouble of short message

To:	Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH][RFC] correction trouble of short message in UDP
From:	Keir Fraser <keir@xxxxxxxxxxxxx>
Date:	Thu, 25 Jan 2007 14:03:19 +0000
Cc:	t.horikoshi@xxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Thu, 25 Jan 2007 06:03:04 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<E1HA4q4-0003aC-00@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AcdAiZD0z3KIeax8EduKvwAX8io7RQ==
Thread-topic:	[Xen-devel] [PATCH][RFC] correction trouble of short message in UDP
User-agent:	Microsoft-Entourage/11.2.5.060620

On 25/1/07 13:40, "Herbert Xu" <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> How about making the total number of grant table entries equal the
> number of TX slots? That way we won't have to check anything at all.
> 
> It also doesn't make sense to have more TX slots than grant table entries.

Yes, this is a good idea!

So we should replace current netfront_tx_slot_available implementation with:
 (tx->req_prod_pvt - tx->rsp_cons) < (TX_MAX_TARGET - MAX_SKB_FRAGS - 2)

??

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH][RFC] correction trouble of short message in UDP