WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] [PATCH 4/4] HVM save/restore clean up: enable 64 guest on 64

To: Ian Pratt <Ian.Pratt@xxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>, Tim Deegan <Tim.Deegan@xxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH 4/4] HVM save/restore clean up: enable 64 guest on 64 HV
From: "Zhai, Edwin" <edwin.zhai@xxxxxxxxx>
Date: Sat, 20 Jan 2007 00:40:02 +0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, edwin.zhai@xxxxxxxxx
Delivery-date: Fri, 19 Jan 2007 08:39:52 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.11
[PATCH 4/4] HVM save/restore clean up: enable 64 guest on 64 HV

Signed-off-by: Zhai Edwin <edwin.zhai@xxxxxxxxx>

remove the assumption that sh_update_paging_modes only occur on current vcpu.
64b guest can be save/restored on 64b HV with this.
need reconsider it for security.

diff -r a4373c8e7e2d xen/arch/x86/mm/shadow/common.c
--- a/xen/arch/x86/mm/shadow/common.c   Fri Jan 19 19:40:12 2007 +0800
+++ b/xen/arch/x86/mm/shadow/common.c   Fri Jan 19 19:42:42 2007 +0800
@@ -2575,8 +2575,6 @@ static void sh_update_paging_modes(struc
                                   "this HVM vcpu's (d=%u v=%u) paging mode!\n",
                                   current->domain->domain_id, current->vcpu_id,
                                   v->domain->domain_id, v->vcpu_id);
-                    domain_crash(v->domain);
-                    return;
                 }
 
                 old_mfn = pagetable_get_mfn(v->arch.monitor_table);
@@ -2590,7 +2588,8 @@ static void sh_update_paging_modes(struc
                  * pull it down!  Switch CR3, and warn the HVM code that
                  * its host cr3 has changed. */
                 make_cr3(v, mfn_x(new_mfn));
-                write_ptbase(v);
+                if ( v == current )
+                    write_ptbase(v);
                 hvm_update_host_cr3(v);
                 old_mode->destroy_monitor_table(v, old_mfn);
             }

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH 4/4] HVM save/restore clean up: enable 64 guest on 64 HV, Zhai, Edwin <=