WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Partial fix for compat build non-portability

To: Keir Fraser <keir@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Partial fix for compat build non-portability
From: John Levon <levon@xxxxxxxxxxxxxxxxx>
Date: Wed, 17 Jan 2007 15:42:39 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 17 Jan 2007 07:40:25 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C1D3EC1F.7C06%keir@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070111162959.GA25963@xxxxxxxxxxxxxxxxxxxxxxx> <C1D3EC1F.7C06%keir@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Wed, Jan 17, 2007 at 03:07:11PM +0000, Keir Fraser wrote:

> >> We only care about it working for the x86/64 target since that's the only
> >> one that asserts CONFIG_COMPAT. Why would wrapping structs individually be
> >> better than wrapping whole header files?
> > 
> > I've been building with the below, but haven't verified it's correct.
> 
> I'm confused about the purpose of changing this. Does pragma push/pop not
> work properly for some reason, or break the build?

For some reason it's target specific in gcc, and specifically not
enabled for sysv targets like Solaris.

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel