WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [RFC] Re: [Xen-devel] [PATCH] fix xenctl_cpumap translation to handl

To: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
Subject: Re: [RFC] Re: [Xen-devel] [PATCH] fix xenctl_cpumap translation to handle bitops accessed like arrays
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Wed, 17 Jan 2007 13:55:39 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 17 Jan 2007 05:55:15 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <95B80CFB-BE47-450C-978C-D0A396F1D1B2@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acc6Pyt4afUViqYyEduIGwAX8io7RQ==
Thread-topic: [RFC] Re: [Xen-devel] [PATCH] fix xenctl_cpumap translation to handle bitops accessed like arrays
User-agent: Microsoft-Entourage/11.2.5.060620


On 17/1/07 12:50, "Jimi Xenidis" <jimix@xxxxxxxxxxxxxx> wrote:

>> Actually, your
>> 'no-op' long_to_byte_bitmap() implementation does not memcpy -- why
>> is that?
> 
> This is a little (possibly dirty) attempt to avoid a copy if no
> conversion is required.
> As long as the caller uses the return value all is well.
> I'd happy to make it a memcpy() and feel better about it.

Yes please.

 K.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel