Re: [Xen-devel] [PATCH] ptwr_emulate adjustments

["Jan Beulich" <jbeulich@xxxxxxxxxx>]

>> - dump guest execution state when emulation fails
>
>We can't put anything more than XENLOG_G_WARNING on a path that a guest can
>exercise at will. One option is to make show_execution_state (and hence all
>underlying state-dump functions) take the dump log level as a parameter.

Oh, understood. I'm not insisting on this part. It just helped me in debugging.

>> - use the passed in register pointer rather than re-calculating
>>   guest_cpu_user_regs()
>
>The assertion is broken and anyway really a bit overkill imo. Using regs
>rather than guest_cpu_user_regs() makes sense.

While I don't understand why it's broken (I just added it to check in debug 
builds
that the value now used matches the one previously used), but I'm fully with
you to remove it if you agree that using the function parameter is okay.

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel