WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] kexec/kdump: fix grammar in comment

To: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] kexec/kdump: fix grammar in comment
From: Horms <horms@xxxxxxxxxxxx>
Date: Thu, 11 Jan 2007 12:35:34 +0900
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Magnus Damm <magnus.damm@xxxxxxxxx>
Delivery-date: Wed, 10 Jan 2007 19:38:13 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1168421358.24570.25.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070110080337.GA4687@xxxxxxxxxxxx> <1168421358.24570.25.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: mutt-ng/devel-r804 (Debian)
On Wed, Jan 10, 2007 at 09:29:18AM +0000, Ian Campbell wrote:
> On Wed, 2007-01-10 at 17:03 +0900, Horms wrote:
> > Fix the grammar in the comment that features in
> > xen_machine_kexec_setup_resources(). The current
> > edition is a bit odd.
> 
> What I was trying to say is that we allow a possible memory leak because
> the failure is unexpected and the amount is small, your version doesn't
> really convey that information.
> 
> I've changed it to:
> 
>       * It isn't possible to free xen_phys_cpus this early in the 
>       * boot. Failure at this stage is unexpected and the
>       * amount of memory is small therefore we tolerate the
>       * potential leak.

Thanks.

-- 
Horms
  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel