WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [Patch] Fix the slow wall clock time issue in x64 SMP Vi

To: "Keir Fraser" <keir@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [Patch] Fix the slow wall clock time issue in x64 SMP Vista
From: "Cui, Dexuan" <dexuan.cui@xxxxxxxxx>
Date: Wed, 10 Jan 2007 19:53:46 +0800
Delivery-date: Wed, 10 Jan 2007 03:54:14 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C1CA8053.7662%keir@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acc0qpECUWE/uVerTTS+WkRpZ1GU0QAAQ2zNAABGKxA=
Thread-topic: [Xen-devel] [Patch] Fix the slow wall clock time issue in x64 SMP Vista
1) I made the change mainly for timer1 of HPET. Actually I don't know exactly 
how x64 SMP Vista uses HPET's timer1 to adjust the wall clock time; but without 
the patch, HPET's timer1 can generate and inject interrupts with a frequency of 
20KHz or so! and the wall clock time would become slow.

2) Yes. I think the vcpu_kick() in hpet_timer_fn() is actually unnecessary. 
Thanks for pointing out this!

 -- Dexuan

-----Original Message-----
From: Keir Fraser [mailto:keir@xxxxxxxxxxxxx] 
Sent: 2007年1月10日 19:37
To: Cui, Dexuan; xen-devel@xxxxxxxxxxxxxxxxxxx
Cc: Keir Fraser
Subject: Re: [Xen-devel] [Patch] Fix the slow wall clock time issue in x64 SMP 
Vista

On 10/1/07 11:29, "Cui, Dexuan" <dexuan.cui@xxxxxxxxx> wrote:

> In x64 SMP Vista HVM guest (vcpus=2 in the configuration file), the wall
> clock time is 50% slower than that in the real world. The attached patch
> fixes the issue.

Looks like this code will inject fewer HPET interrupts. How does that make
time go *faster*?

Also, looking at hpet_timer_fn() is vcpu_kick() actually required? The PIC
logic invoked from hpet_route_interrupt() should do any required kicking.

 -- Keir

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel