WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] linux/i386: allow CONFIG_HIGHPTE on i386

To: "Keir Fraser" <keir@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] linux/i386: allow CONFIG_HIGHPTE on i386
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Wed, 10 Jan 2007 11:14:32 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 10 Jan 2007 03:12:44 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C1CA771B.762E%keir@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <45A4C6B5.76E4.0078.0@xxxxxxxxxx> <C1CA771B.762E%keir@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Keir Fraser <keir@xxxxxxxxxxxxx> 10.01.07 11:57 >>>
>On 10/1/07 09:57, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:
>
>> The patch at once does away with the use of PageForeign on pte pages, to 
>> match
>> x86-64 and to reduce the delta to native.
>
>Is it actually safe to circumvent tlb_remove_page()? It does rather more
>than just free_page()! That's why I used a ForeignPage hook when writing the
>i386 code. It's certainly *not* safe to assume that whoever wrote that part
>of the x86/64 port understood all the ramifications of what they were doing.

Not really, as I understand it - it either frees the page (when the TLB is in 
fast
mode) or inserts the page into the gather list, bumping the contained pages
count and freeing all of them and flushing the hardware TLBs if exceeding the
threshold - the latter step is otherwise done from tlb_finish_mmu().

And - I asked about this inconsistency between i386 and x86-64 before
submitting the patch, with no useful responses...

Jan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel