 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] trivial simplifcation in xen/arch/x86/mm.c
| To: | Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] trivial simplifcation in xen/arch/x86/mm.c |
| From: | Keir Fraser <keir@xxxxxxxxxxxxx> |
| Date: | Wed, 10 Jan 2007 10:45:08 +0000 |
| Delivery-date: | Wed, 10 Jan 2007 02:44:52 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <45A4C536.76E4.0078.0@xxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | Acc0pGUro3mmpKCXEduNDgAX8io7RQ== |
| Thread-topic: | [Xen-devel] [PATCH] trivial simplifcation in xen/arch/x86/mm.c |
| User-agent: | Microsoft-Entourage/11.2.5.060620 |
On 10/1/07 09:51, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote: > Replace mfn_to_page(lXe_get_pfn()) by lXe_get_page(). > > However, what I got surprised by while looking for all of these is that > ptwr_emulated_update() uses gmfn_to_mfn() on the pte loaded from the > emulation context, while ptwr_do_page_fault() doesn't on the pte stored > into that context. Shouldn't these two be symmetric? > > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx> Yes. Shadow_mode_translate without shadow_mode_refcount is horribly broken in various ways, but I'll fix this particular confusion at least. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [PATCH] kexec/kdump: fix grammar in comment, Keir Fraser |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH] linux/i386: allow CONFIG_HIGHPTE on i386, Keir Fraser |
| Previous by Thread: | [Xen-devel] [PATCH] trivial simplifcation in xen/arch/x86/mm.c, Jan Beulich |
| Next by Thread: | [Xen-devel] [PATCH] linux/i386: allow CONFIG_HIGHPTE on i386, Jan Beulich |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
