Re: [Xen-devel] [PATCH] the address of 'symbols_addresses' will

To:	<caglar@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] the address of 'symbols_addresses' will always evaluate as 'true'
From:	Keir Fraser <keir@xxxxxxxxxxxxx>
Date:	Wed, 10 Jan 2007 10:31:30 +0000
Delivery-date:	Wed, 10 Jan 2007 02:31:16 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<200701100318.16115.caglar@xxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	Acc0on2avBuvI6CVEduNDgAX8io7RQ==
Thread-topic:	[Xen-devel] [PATCH] the address of 'symbols_addresses' will always evaluate as 'true'
User-agent:	Microsoft-Entourage/11.2.5.060620

On 10/1/07 01:18, "S.Çağlar Onur" <caglar@xxxxxxxxxxxxx> wrote:

> Attached patch adds "-Wno-always-true" CFLAGS into xen/arch/powerpc/Rules.mk
> and xen/arch/x86/Rules.mk, else compiling xen with latest gcc-4.2.0 snapshot
> fails, patch is against current xen-3.0.4-testing repo;

If that is the *only* build error, then we can just get rid of that
BUG_ON(). It doesn't work any more anyway (that symbol is never zero, even
during initial kernel link when no symbol info is available).
BUG_ON(symbols_num_syms == 0) is probably the right replacement.

 -- Keir

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH] the address of 'symbols_addresses' will always e