WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 6/7] Fix xm create direct call to XendBootloader

To: John Levon <levon@xxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 6/7] Fix xm create direct call to XendBootloader
From: Ewan Mellor <ewan@xxxxxxxxxxxxx>
Date: Fri, 5 Jan 2007 17:22:55 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 05 Jan 2007 09:22:40 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070105165317.GE30085@xxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070105165017.GA29771@xxxxxxxxxxxxxxxxxxxxxxx> <20070105165317.GE30085@xxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Fri, Jan 05, 2007 at 04:53:17PM +0000, John Levon wrote:

> 
> Fix xm create direct call to XendBootloader
> 
> Signed-off-by: John Levon <john.levon@xxxxxxx>
> 
> diff --git a/tools/python/xen/xm/create.py b/tools/python/xen/xm/create.py
> --- a/tools/python/xen/xm/create.py
> +++ b/tools/python/xen/xm/create.py
> @@ -719,8 +719,11 @@ def run_bootloader(vals, config_image):
>               "--entry= directly.")
>          vals.bootargs = "--entry=%s" %(vals.bootentry,)
>  
> +    kernel = sxp.child_value(config_image, 'kernel')
> +    ramdisk = sxp.child_value(config_image, 'ramdisk')
> +    args = sxp.child_value(config_image, 'args')
>      return bootloader(vals.bootloader, file, not vals.console_autoconnect,
> -                      vals.bootargs, config_image)
> +                      vals.bootargs, kernel, ramdisk, args)
>  
>  def make_config(vals):
>      """Create the domain configuration.

Surely there's no reason for xm to be running the bootloader directly?!  That
doesn't make any sense.  Can't we just delete all of this code?

Ewan.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel