Re: [Xen-devel] [PATCH 6/7] Fix xm create direct call to XendBootloader

[Ewan Mellor <ewan@xxxxxxxxxxxxx>]

On Fri, Jan 05, 2007 at 04:53:17PM +0000, John Levon wrote:

> 
> Fix xm create direct call to XendBootloader
> 
> Signed-off-by: John Levon <john.levon@xxxxxxx>
> 
> diff --git a/tools/python/xen/xm/create.py b/tools/python/xen/xm/create.py
> --- a/tools/python/xen/xm/create.py
> +++ b/tools/python/xen/xm/create.py
> @@ -719,8 +719,11 @@ def run_bootloader(vals, config_image):
>               "--entry= directly.")
>          vals.bootargs = "--entry=%s" %(vals.bootentry,)
>  
> +    kernel = sxp.child_value(config_image, 'kernel')
> +    ramdisk = sxp.child_value(config_image, 'ramdisk')
> +    args = sxp.child_value(config_image, 'args')
>      return bootloader(vals.bootloader, file, not vals.console_autoconnect,
> -                      vals.bootargs, config_image)
> +                      vals.bootargs, kernel, ramdisk, args)
>  
>  def make_config(vals):
>      """Create the domain configuration.

Surely there's no reason for xm to be running the bootloader directly?!  That
doesn't make any sense.  Can't we just delete all of this code?

Ewan.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel