WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Enable uppercase letters to be entered in QEMU m

To: "Keir Fraser" <keir@xxxxxxxxxxxxx>, "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Enable uppercase letters to be entered in QEMU monitor terminal
From: "Kasai Takanori" <kasai.takanori@xxxxxxxxxxxxxx>
Date: Wed, 20 Dec 2006 20:15:09 +0900
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 20 Dec 2006 03:15:16 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C193613C.53EB%keir@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi Keir and Daniel,

I also found the same problem and tested this patch.
I confirmed it was solved by this patch.
I hope for this patch to be applied.

Thanks

--
Takanori Kasai


----- Original Message ----- From: "Keir Fraser" <keir@xxxxxxxxxxxxx> To: "Daniel P. Berrange" <berrange@xxxxxxxxxx>; "Keir Fraser" <keir@xxxxxxxxxxxxx>
Cc: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Sent: Thursday, November 30, 2006 1:09 AM
Subject: Re: [Xen-devel] [PATCH] Enable uppercase letters to be entered inQEMU monitor terminal





On 29/11/06 15:48, "Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote:

Doesn't this eat the shift/caps key events even when not in qemu monitor
mode? What if the guest has shortcut key combos involving those keys, for
example?

Re-checking the patch I believe its already doing the correct thing.

The do_key_event method is broken into 2 halfs. In the first half, the
keysyms are sent to either the guest OS, or the monitor. In the second
half the shift/caps/ctrl/alt state is being tracked. So the code I added
for tracking shift/caps does not interfere with the earlier code which
actually sends the key press to the guest OS.

Okay, I'll read the code more carefully. :-)

-- keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>