WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] EFER in HVM guests

To: "Li, Xin B" <xin.b.li@xxxxxxxxx>, "Petersson, Mats" <Mats.Petersson@xxxxxxx>, "Woller, Thomas" <thomas.woller@xxxxxxx>, "Keir Fraser" <keir@xxxxxxxxxxxxx>, "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>, "Jan Beulich" <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] EFER in HVM guests
From: "Li, Xin B" <xin.b.li@xxxxxxxxx>
Date: Tue, 19 Dec 2006 15:04:22 +0800
Delivery-date: Mon, 18 Dec 2006 23:04:20 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AccTv6r97XujPIxiQ5aNfYfQKg41qAAEUxeAAAJ45NkCtmyz4AAD6ZnBAGdepCAAkrUBoAAC2DfgAB80i2AAAb9z4A==
Thread-topic: [Xen-devel] EFER in HVM guests
>>
>>Just out of curiosity, why did you change the parameters 
>>passed to svm_do_cpuid - I can see why you wouldn't need to 
>>pass regs->eax when it's available in regs, but digging out 
>>the vmcb again can't be better than passing the already 
>>existing one? [Don't worry about it, I'm just curious about 
>>why the change was made]. 
>
In svm code, you don't always pass vmcb as input paramter, for example,
svm_do_msr_access, it's a little bit confusing, I think you need clean
it up.
-Xin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel