WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] bug in default interface number computation

Subject: Re: [Xen-devel] [PATCH] bug in default interface number computation
From: Guillaume Rousse <Guillaume.Rousse@xxxxxxxx>
Date: Mon, 18 Dec 2006 13:13:02 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 18 Dec 2006 04:11:46 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20061218114816.GC22626@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4586679B.40007@xxxxxxxx> <20061218114816.GC22626@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 1.5.0.8 (X11/20061109)
Ewan Mellor wrote:
> On Mon, Dec 18, 2006 at 11:04:11AM +0100, Guillaume Rousse wrote:
> 
>> As previously explained, the network-bridge script tries to
>> automatically find the default network interface number with the
>> following ligne:
>> vifnum=${vifnum:-$(ip route list | awk '/^default / { print $NF }' | sed
>> 's/^[^0-9]*//')}
>>
>> However, this fails on mandriva, because the parsed line is:
>> default via 193.55.250.126 dev eth0  metric 10
>>
>> Attached patch fix this issue.
>>
>> BTW, that's the second time I'm sending it, I've had no answer sofar. If
>>  this is not the recommanded way to declare problems and send correction
>> patches, just tell me.
> 
> Sorry about missing it the first time.  Your patch looks fine to me -- if you
> could just resend it with a Signed-off-by line, I'll put it in.

If I understand correctly, I just have to add this line, right ?

Signed-off-by: Guillaume Rousse <Guillaume.Rousse@xxxxxxxx>
diff -Naur xen-3.0.3_0-src/tools/examples/network-bridge 
xen-3.0.3_0-src.fix_network_bridge/tools/examples/network-bridge
--- xen-3.0.3_0-src/tools/examples/network-bridge       2006-10-15 
14:22:03.000000000 +0200
+++ xen-3.0.3_0-src.fix_network_bridge/tools/examples/network-bridge    
2006-12-18 10:58:38.000000000 +0100
@@ -59,7 +59,7 @@
 findCommand "$@"
 evalVariables "$@"
 
-vifnum=${vifnum:-$(ip route list | awk '/^default / { print $NF }' | sed 
's/^[^0-9]*//')}
++vifnum=${vifnum:-$(ip route list 0.0.0.0/0 | sed 
's/.*dev[^0-9]\+\([0-9]\+\).*$/\1/')}
 vifnum=${vifnum:-0}
 bridge=${bridge:-xenbr${vifnum}}
 netdev=${netdev:-eth${vifnum}}
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>