WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] yet another package check

To: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] yet another package check
From: "Christoph Egger" <Christoph.Egger@xxxxxxx>
Date: Thu, 14 Dec 2006 15:22:15 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 14 Dec 2006 06:22:36 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <4581688F.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: AMD / OSRC
References: <4581688F.76E4.0078.0@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.4
Why do you write non-portable shell scripts?

Some time ago, I made these portable:

check_brctl
check_iproute
check_libvncserver
check_python
check_sdl
check_zlib_devel
check_zlib_lib

For now, the non-portable scripts are:

check_crypto_lib
check_openssl_devel
check_python_devel
check_udev
check_x11_devel

Can you make them portable (again), please?



On Thursday 14 December 2006 15:06, you wrote:
> As before, the file added to tools/check/ must be given exec permission.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
>
> Index: 2006-12-11/tools/Makefile
> ===================================================================
> --- 2006-12-11.orig/tools/Makefile    2006-12-04 08:49:57.000000000 +0100
> +++ 2006-12-11/tools/Makefile 2006-12-14 14:25:02.000000000 +0100
> @@ -36,7 +36,7 @@ all: check
>       $(MAKE) ioemu
>
>  .PHONY: install
> -install: check
> +install: check_install
>       @set -e; for subdir in $(SUBDIRS-y); do \
>               $(MAKE) -C $$subdir $@; \
>       done
> @@ -58,6 +58,10 @@ distclean: clean
>  check:
>       $(MAKE) -C check
>
> +.PHONY: check_install
> +check_install: check
> +     $(MAKE) -C check install
> +
>  .PHONY: check_clean
>  check_clean:
>       $(MAKE) -C check clean
> Index: 2006-12-11/tools/check/check_python_xml
> ===================================================================
> --- /dev/null 1970-01-01 00:00:00.000000000 +0000
> +++ 2006-12-11/tools/check/check_python_xml   2006-12-14 14:05:30.000000000
> +0100 @@ -0,0 +1,16 @@
> +#!/bin/bash
> +# CHECK-INSTALL
> +
> +function error {
> +    echo
> +    echo "  *** Check for python-xml package FAILED"
> +    exit 1
> +}
> +
> +python -c '
> +import os.path, sys
> +for p in sys.path:
> +     if os.path.exists(p + "/xml/dom/minidom.py"):
> +             sys.exit(0)
> +sys.exit(1)
> +' || error
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel