WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] fix multicall state tracking

To: Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] fix multicall state tracking
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Thu, 14 Dec 2006 10:36:16 +0000
Delivery-date: Thu, 14 Dec 2006 02:36:21 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <457EBD07.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Accfa67r7aLb6oteEdu2MgAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] fix multicall state tracking
User-agent: Microsoft-Entourage/11.2.5.060620
On 12/12/06 13:30, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> This replaces the previous fix to multicall state tracking so that now the
> multicall-
> in-progress status is maintained on a per-VCPU basis (all other state remains
> per physical CPU). This seems cleaner than the previous hack requiring
> clearing
> of the flags in domain_crash_synchronous().
> 
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

I decided to entirely move away from domain_crash_synchronous() in hypercall
context. So the code in domain_crash_synchronous() is just a warning for
errant code -- later it can become BUG_ON(). This means that multicall state
can remain per-cpu, unless per-vcpu seems much better (personally I think it
doesn't really matter either way so we may as well stick with what we have).

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>