WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] [xend] Host.get_resident_VMs RPC

To: Jim Fehlig <jfehlig@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] [xend] Host.get_resident_VMs RPC
From: Ewan Mellor <ewan@xxxxxxxxxxxxx>
Date: Wed, 13 Dec 2006 14:44:54 +0000
Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 13 Dec 2006 06:44:51 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <457DBACC.6000206@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <457DBACC.6000206@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Mon, Dec 11, 2006 at 01:08:44PM -0700, Jim Fehlig wrote:

> I've noticed that Host.get_resident_VMs RPC returns duplicate references 
> to running VMs.  Is this the intent or a bug :-)?  In XendDomain.py we have
> 
>    def get_domain_refs(self):
>        result = []
>        try:
>            self.domains_lock.acquire()
>            result = [d.get_uuid() for d in self.domains.values()]
>            result += self.managed_domains.keys()
>            return result
>        finally:
>            self.domains_lock.release()
> 
> and as you can see a running domain would be included twice in the 
> resulting list.  If this is a bug, patch attached.  If intentional, 
> please let me know so I can handle it appropriately in client code.
> 
> Regards,
> Jim

> # HG changeset patch
> # User jfehlig@xxxxxxxxxxxxxxxxxxxxxxxxx
> # Date 1165867640 25200
> # Node ID 687e576ee99eb68d10324d0013bfd9acc372468c
> # Parent  37141c3a3d39956ad5faf2d4e2a91276eaca557b
> When enumerating VMs resident on a host (Host.get_resident_VMs RPC), ensure 
> VMs with same UUID only appear once in the list.
> 
> Signed-off-by: Jim Fehlig <jfehlig@xxxxxxxxxx>

That wasn't the intention, no!  I've applied that, thanks Jim.

Ewan.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>