WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [patch] Add more xc_error_code values.

To: Gerd Hoffmann <kraxel@xxxxxxx>
Subject: Re: [Xen-devel] [patch] Add more xc_error_code values.
From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Date: Fri, 8 Dec 2006 15:35:26 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 08 Dec 2006 07:35:30 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20061208150949.320661000@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20061208150949.320661000@xxxxxxx>
Reply-to: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Fri, Dec 08, 2006 at 04:09:58PM +0100, Gerd Hoffmann wrote:
> XC_INVALID_PARAM
>   such as asking for features unsupported by either xen or guest kernel.
> XC_OUT_OF_MEMORY
>   no comment ;)
> 
> Signed-off-by: Gerd Hoffmann <kraxel@xxxxxxx>
> ---
>  tools/libxc/xenctrl.h |    2 ++
>  1 file changed, 2 insertions(+)
> 
> Index: build-32-unstable-12802/tools/libxc/xenctrl.h
> ===================================================================
> --- build-32-unstable-12802.orig/tools/libxc/xenctrl.h
> +++ build-32-unstable-12802/tools/libxc/xenctrl.h
> @@ -687,6 +687,8 @@ typedef enum {
>    XC_ERROR_NONE = 0,
>    XC_INTERNAL_ERROR = 1,
>    XC_INVALID_KERNEL = 2,
> +  XC_INVALID_PARAM = 3,
> +  XC_OUT_OF_MEMORY = 4,
>  } xc_error_code;

You'll also want to add matching user friendly descriptions to the method
xc_error_code_to_description in tools/libxc/xc_private.c otherwise they'll
just get converted into 'Unknown error code'.  I thought I had a comment
to this effect just before the declaration of xc_error_code enum, but looks
like I mislaid it.

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>