xen-devel

[Top] [All Lists]

Re: [Xen-devel] [Patch] tweak error reporting for bootloader errors in x

from [Ewan Mellor]

[Permanent Link][Original]

To:	"Daniel P. Berrange" <berrange@xxxxxxxxxx>
Subject:	Re: [Xen-devel] [Patch] tweak error reporting for bootloader errors in xm
From:	Ewan Mellor <ewan@xxxxxxxxxxxxx>
Date:	Thu, 7 Dec 2006 12:10:59 +0000
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Thu, 07 Dec 2006 04:11:00 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<20061106151430.GA9932@xxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<20061106151430.GA9932@xxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mutt/1.5.9i

On Mon, Nov 06, 2006 at 03:14:33PM +0000, Daniel P. Berrange wrote:

> The xm command does some basic validation of the 'bootloader' parameter
> before trying to run it, however, the level of detail reported isn't as
> clear as it could be.
> 
> For example if I typo the bootloader param it says:
> 
>   # xm create XenGuest1
>   Using config file "XenGuest1".
>   Error: Bootloader isn't executable
> 
> The attached patch makes it do an explicit check for path existance prior
> to the one for executable permissions. It also prints out the path being
> tested.
> 
>   # xm create XenGuest1
>   Using config file "XenGuest1".
>   Error: Bootloader '/usr/sbin/pygrub' does not exist
> 
> 
>   Signed-off-by: Daniel P, Berrange <berrange@xxxxxxxxxx>

Applied, thanks, and sorry for the delay.

Ewan.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [Xen-devel] [Patch] tweak error reporting for bootloader errors in xm, Ewan Mellor <=

Previous by Date:	Re: [Xen-devel] [Patch] Make SEXPR HTTP service multi-threaded, Ewan Mellor
Next by Date:	Re: [Xen-devel] [PATCH] Scrub VNC passwords from XenD log files, Ewan Mellor
Previous by Thread:	Re: [Xen-devel] [Patch] Make SEXPR HTTP service multi-threaded, Ewan Mellor
Next by Thread:	[Xen-devel] [PATCH] make XEN_DOMCTL_getdomaininfo return shared_info_frame in gmfn, Isaku Yamahata
Indexes:	[Date] [Thread] [Top] [All Lists]