WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] [XEND] fix vif IP specification broken in 12633:

To: Ewan Mellor <ewan@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] [XEND] fix vif IP specification broken in 12633:5bed7bc05c8a
From: Brendan Cully <brendan@xxxxxxxxx>
Date: Tue, 5 Dec 2006 16:22:34 -0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 05 Dec 2006 16:22:41 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20061205232147.GB10736@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: ewan@xxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx
References: <013e995e2a6b0c5b237b.1165276770@xxxxxxxxxxxxxxxxx> <20061205205118.GA13614@xxxxxxxxxxxxxxxxx> <20061205232147.GB10736@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.13 (2006-11-21)
On Tuesday, 05 December 2006 at 23:21, Ewan Mellor wrote:
> On Tue, Dec 05, 2006 at 12:51:19PM -0800, Brendan Cully wrote:
> 
> > On Monday, 04 December 2006 at 15:59, Brendan Cully wrote:
> > > # HG changeset patch
> > > # User Brendan Cully <brendan@xxxxxxxxx>
> > > # Date 1165276659 28800
> > > # Node ID 013e995e2a6b0c5b237b29211e697b7757e5f94f
> > > # Parent  fd28a1b139dea91b8bfcf06dd233dbdda8f51ff1
> > > [XEND] fix vif IP specification broken in 12633:5bed7bc05c8a
> > > 
> > > Apparently at some point one could attach multiple IP addresses
> > > to a single VIF in the config file. This doesn't address that
> > > feature.
> > > 
> > > Signed-off-by: Brendan Cully <brendan@xxxxxxxxx>
> > 
> > Sorry, I should have included a better description of the problem:
> > 
> > vif = ['ip=xxx.xxx.xxx.xxx'] hasn't worked since 12633 (at least with
> > Xen's nat scripts). The problem is that pre-12633, the IP field
> > returned from the config parser was a list, but now it is a string. So
> > ' '.join(ip) ends up sending 'x x x . x x x . x x x . x x x' to the
> > scripts, which were expecting less whitespace.
> 
> So does your fix mean that multiple IP addresses work again, or can we
> only have one address this way?  I'd prefer to fix the config parser if
> that's what's needed to support multiple IP addresses, since it
> certainly used to work.

This patch only supports a single IP address. It should easy enough to
support a list again, but I didn't see an example of the config file
syntax for multiple IPs. I presume the delimiter isn't ',' or '
'. Perhaps it's ['ip=foo, ip=bar'] ?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel