[Xen-devel] Re: [PATCH] [Xm-Test] XenManagedDomain and initial test case for vTPM management using xen-api

[Stefan Berger <stefanb@xxxxxxxxxx>]

Ewan Mellor <ewan@xxxxxxxxxxxxx> wrote on 12/01/2006
12:36:47 PM:

> On Tue, Nov 28, 2006 at 04:37:31PM -0500, Stefan Berger wrote:
> 
> > This patch provides XmTestManagedDomain and XenManagedDomain
classes
> > similar to the XmTestDomain and XenDomain classes. I have wrapped
the
> > xen-api for VM configuration creation, starting and stopping
of VMs and
> > destruction of the VM configuration in the XenManagedDomain class's
> > methods. No device-related functions are provided through the
class.
> > 
> > The managed domains' UUIDs are tracked and all created VMs are
destroyed
> > upon failure or skipping of the test or by calling
> > xapi.vm_destroy_all().
> > 
> > I am adding a new grouptest 'xapi' for running xen-api tests.
> > 
> > Only caveat: I am using an empty username and password
> > (XmTestList/xapi.py) with Xend's authentication deactivated to
run these
> > tests.
> > 
> > Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxx>
> 
> Applied, thanks Stefan.  Now all we need is some tests that _don't_
need a TPM
> ;-)

Yes, I understand that, but I must say that I don't
know what would be the best way to go about it and maybe what has been
committed so far is not that good. One could either cut and paste all existing
tests and modify them to work with the xen-api, or we could use a global
variable 'xapi' that allows us to resuse existing tests like this:

if (xapi)
        domain = XenManagedTestDomain()
else
        domain = XenTestDomain()

This way all tests would need to be run twice.

And then the question is whether XenManagedTestDomain()
should not rather be implemented with XenTestDomain(managed=xapi), which
would lead to a messier implementation inside XenTestDomain().

Often there are statements in the tests like traceCommand('xm
xyz'), which would also need to be surrounded with an if (xapi) statement.
I guess the goal could be to reduce the test implementation work while
not messing up the implementations.

Thoughts?

   Stefan


> 
> Ewan.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel