[Xen-devel] Re: [PATCH] ARCH_HAS_DEV_MEM_MMAP_MEM fix

To:	Alex Williamson <alex.williamson@xxxxxx>
Subject:	[Xen-devel] Re: [PATCH] ARCH_HAS_DEV_MEM_MMAP_MEM fix
From:	Keir Fraser <keir@xxxxxxxxxxxxx>
Date:	Fri, 01 Dec 2006 09:56:41 +0000
Cc:	xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Fri, 01 Dec 2006 01:56:52 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<1164926187.6117.29.camel@lappy>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AccVLv/wPol84IEiEduAwAAX8io7RQ==
Thread-topic:	[PATCH] ARCH_HAS_DEV_MEM_MMAP_MEM fix
User-agent:	Microsoft-Entourage/11.2.5.060620

On 30/11/06 22:36, "Alex Williamson" <alex.williamson@xxxxxx> wrote:

>    We can't really define our own mmap_mem external from
> driver/xen/char/mem.c as long as drivers/char/mem.c is defining a static
> version.  Patch below solves the problem.  Thanks,

mmap_mem() in drivers/char/mem.c is still used by mmap_kmem(). We'll get a
compile warning if the local static definition of mmap_mem() is removed
(plus I think the native mmap_mem is the right one to use for mmap_kmem, at
least on x86). Perhaps we should rename the Xen mmap_mem to xen_mmap_mem?

 -- Keir

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

[Xen-devel] Re: [PATCH] ARCH_HAS_DEV_MEM_MMAP_MEM fix