 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] add canonical address checks to HVM
| To: | Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] add canonical address checks to HVM |
| From: | Keir Fraser <keir@xxxxxxxxxxxxx> |
| Date: | Thu, 30 Nov 2006 17:55:55 +0000 |
| Delivery-date: | Thu, 30 Nov 2006 09:56:04 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <456DAFBE.76E4.0078.0@xxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AccUqMg/BvWTMYCcEdubHwAX8io7RQ== |
| Thread-topic: | [Xen-devel] [PATCH] add canonical address checks to HVM |
| User-agent: | Microsoft-Entourage/11.2.5.060620 |
On 29/11/06 15:05, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote: > Add proper long mode canonical address checks to PIO emulation and MSR > writes, the former paralleling the limit checks added for 32-bit guests. > Also catches two more cases in the MSR handling code where only ECX > (rather than RCX) should be used. > > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx> I wonder if we would be better consistently *removing* the canonical-address checks? It's not a security issue after all -- the check is done in hardware only to prevent code from ever depending on being able to use the high address bits for software flags. I think it is harmless to deviate from native behaviour on this issue and makes our emulation code smaller and simpler. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [RFC][PATCH] 3/3] [TOOLS][XENTRACE] Various tidyups to xentrace tools., Mark Williamson |
|---|---|
| Next by Date: | Re: [Xen-devel] VMX status report 12618:463bda167715, Ewan Mellor |
| Previous by Thread: | [Xen-devel] [PATCH] add canonical address checks to HVM, Jan Beulich |
| Next by Thread: | [Xen-devel] [PATCH] fix Solaris build for xc.c, John Levon |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
