 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] Enable uppercase letters to be entered in QEMU m
| To: | "Daniel P. Berrange" <berrange@xxxxxxxxxx>, Keir Fraser <keir@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] Enable uppercase letters to be entered in QEMU monitor terminal |
| From: | Keir Fraser <keir@xxxxxxxxxxxxx> |
| Date: | Wed, 29 Nov 2006 16:09:32 +0000 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Wed, 29 Nov 2006 08:09:39 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <20061129154841.GA16682@xxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AccT0MFF/6Nvun/DEducNwAX8io7RQ== |
| Thread-topic: | [Xen-devel] [PATCH] Enable uppercase letters to be entered in QEMU monitor terminal |
| User-agent: | Microsoft-Entourage/11.2.5.060620 |
On 29/11/06 15:48, "Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote: >> Doesn't this eat the shift/caps key events even when not in qemu monitor >> mode? What if the guest has shortcut key combos involving those keys, for >> example? > > Re-checking the patch I believe its already doing the correct thing. > > The do_key_event method is broken into 2 halfs. In the first half, the > keysyms are sent to either the guest OS, or the monitor. In the second > half the shift/caps/ctrl/alt state is being tracked. So the code I added > for tracking shift/caps does not interfere with the earlier code which > actually sends the key press to the guest OS. Okay, I'll read the code more carefully. :-) -- keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [PATCH] non-flat protected mode HVM support, Keir Fraser |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH] fixes for suspend & resume, Chris |
| Previous by Thread: | Re: [Xen-devel] [PATCH] Enable uppercase letters to be entered in QEMU monitor terminal, Daniel P. Berrange |
| Next by Thread: | [Xen-devel] Live migration leaves page tables read-only?, John Byrne |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
