WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH] make ballooning up to maxmem work

To: Keir Fraser <keir@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH] make ballooning up to maxmem work
From: Glauber de Oliveira Costa <gcosta@xxxxxxxxxx>
Date: Wed, 22 Nov 2006 10:47:45 -0200
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 22 Nov 2006 04:47:41 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C189E28F.4DF0%keir@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20061122104021.GA2496@xxxxxxxxxx> <C189E28F.4DF0%keir@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.11
On Wed, Nov 22, 2006 at 11:18:39AM +0000, Keir Fraser wrote:
> 
> 
> 
> On 22/11/06 10:40, "Glauber de Oliveira Costa" <gcosta@xxxxxxxxxx> wrote:
> 
> >>      case XENMEM_current_reservation:
> >>      case XENMEM_maximum_reservation:
> >> +    case XENMEM_maximum_memory:
> >>          if ( copy_from_guest(&domid, arg, 1) )
> >>              return -EFAULT;
> > 
> > This still makes use of d->max_pages in return. Isn't it supposed to
> > change in the future too? IIRC, according to Keir, max_pages will track
> > the _current_ number of pages, differing from tot_pages only in a brief
> > timeframe in which you balloon, but tot_pages was not yet updated.
> 
> This adds a level of indirection at least, but really we may as well
> implement the XENMEM_memory_map hypercall. Then there is no guest
> modification required.

We may need guest modifications anyway, since currently no actions are
performed if the memory_map call does not return ENOSYS. 
 

-- 
Glauber de Oliveira Costa
Red Hat Inc.
"Free as in Freedom"

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>