WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH] inline VMX functions

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH] inline VMX functions
From: "Li, Xin B" <xin.b.li@xxxxxxxxx>
Date: Mon, 13 Nov 2006 17:03:17 +0800
Delivery-date: Mon, 13 Nov 2006 01:03:55 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AccGzGxsIIVOm6GYQlqxIj8TgPNHxgAMGp1dAAEBseA=
Thread-topic: [Xen-devel] [PATCH] inline VMX functions
>
>Unless the function call is really hot (in an inner loop for example) I
>don't believe that the performance benefit of inlining is 
>measurable (or
>maybe even exists at all). Against that there are the 
>disadvantages that
>debugging from a backtrace becomes much more of a pain (especially that
>vmexit handler, which becomes *really* big!), and there's a 
>tendency for
>'inline' to spread around like a 'go faster' magic dust, applied to
>functions where it really doesn't help. So I'm moderately 
>inclined not to
>take the inlining bits of this patch unless you strongly disagree.
>

OK, let's not take it, such VMExits are small part of total VMExits.
-Xin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>