WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] fix xend not to parse `df`

To: John Levon <levon@xxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] fix xend not to parse `df`
From: Ewan Mellor <ewan@xxxxxxxxxxxxx>
Date: Thu, 9 Nov 2006 23:20:05 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 09 Nov 2006 15:20:21 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20061109230655.GA24273@xxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20061109230655.GA24273@xxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Thu, Nov 09, 2006 at 11:06:55PM +0000, John Levon wrote:

> 
> # HG changeset patch
> # User john.levon@xxxxxxx
> # Date 1163113431 28800
> # Node ID 348c6ec90131ddfe893029fa01dc133bbc77a3ae
> # Parent  d6902275432c8570835d0e962ac7991fcd2c070a
> Parsing 'df' output is extremely non-portable. Replace with a direct 
> statvfs().
> 
> Signed-off-by: John Levon <john.levon@xxxxxxx>

Not that I object to your patch (I don't, and will apply it in the
morning) but is df non-portable even when specifying the -P flag (POSIX /
portability, according to my man page)?

Ewan.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>