WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [Patch] Fix for x86_64 boot failures due to bad segment

To: Keir Fraser <keir@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [Patch] Fix for x86_64 boot failures due to bad segment setup for protected mode.
From: Steven Rostedt <srostedt@xxxxxxxxxx>
Date: Thu, 09 Nov 2006 09:28:35 -0500
Cc: Wilfred Yu <wilfred.yu@xxxxxxxxx>, Xiaohui Xin <xiaohui.xin@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Susie Li <susie.li@xxxxxxxxx>, "Li, Xin B" <xin.b.li@xxxxxxxxx>, Herbert Xu <herbert.xu@xxxxxxxxxx>
Delivery-date: Thu, 09 Nov 2006 06:28:54 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C178E6D1.438A%keir@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C178E6D1.438A%keir@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 1.5.0.4 (X11/20060614)
Keir Fraser wrote:
On 9/11/06 12:56, "Steven Rostedt" <srostedt@xxxxxxxxxx> wrote:

The old approach would just update all the selectors if they fit inside
the GDT table, whether or not they were changed or loaded. So when Linux
had a bad (extremely large) GDT limit, we loaded all the selectors into
the shadow selector, even though they were bogus.

A smaller patch might have been to implement those VMENTER sanity checks
inside load_seg(). I'm sure they're quite simple. However, this new approach
is arguably saner than the old, and it's worked on a few images I've tested
it with, so I checked it in and we'll see how it holds up under wider
testing.


I believed Stephen looked at the sanity check approach, and determined that the code to simulate the sanity checks would be quite complex and error prone. But Stephen can correct me if I'm wrong.

-- Steve



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>