 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] bug? hvm builder memory allocation ...
| To: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>, Gerd Hoffmann <kraxel@xxxxxxx>, Xen devel list <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] bug? hvm builder memory allocation ... |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Tue, 07 Nov 2006 11:56:20 +0000 |
| Delivery-date: | Tue, 07 Nov 2006 03:56:40 -0800 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <C176217D.416C%Keir.Fraser@xxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AccCYbXj9Gn02W5UEdurgAAX8io7RQAAgcre |
| Thread-topic: | [Xen-devel] bug? hvm builder memory allocation ... |
| User-agent: | Microsoft-Entourage/11.2.5.060620 |
Error handling in xc_domain_{increase,decrease}_reservation() was broken.
With that fixed the HVM builder was indeed broken, so I removed the
unnecessary decrease_reservation() call. This is all fixed in c/s
12273:5a41ea282c.
Thanks,
Keir
On 7/11/06 11:41, "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx> wrote:
> Well clearly it works. I'm not sure why though. :-) The
> decrease_reservation() request ought to fail and hence fail the HVM guest
> creation. I'll look into it.
>
> -- Keir
>
> On 7/11/06 11:34, "Gerd Hoffmann" <kraxel@xxxxxxx> wrote:
>
>> Hi,
>>
>> hvm memory allocation looks buggy in unstable: First it allocates
>> memory using two xc_domain_memory_populate_physmap() calls, explicitly
>> excluding the vga hole, then the (not allocated) vga hole is released
>> via xc_domain_memory_decrease_reservation() ...
>>
>> cheers,
>> Gerd
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] Re: [PATCH] [RFC] Moving the e820 table creation, Keir Fraser |
|---|---|
| Next by Date: | Re: [Xen-devel] Re: [PATCH] [RFC] Moving the e820 table creation, Stefan Berger |
| Previous by Thread: | Re: [Xen-devel] bug? hvm builder memory allocation ..., Keir Fraser |
| Next by Thread: | [Xen-devel] Copying to dom0 physical memory, Eric Benton |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
