Re: [Xen-devel] [PATCH] Fix parameter check of xm dmesg

[Ewan Mellor <ewan@xxxxxxxxxxxxx>]

On Tue, Oct 31, 2006 at 03:07:57PM +0900, Masaki Kanno wrote:

Content-Description: Mail message body
> Hi,
> 
> I found a small bug in xm dmesg command.  Even if I gave xm dmesg 
> command a wrong parameter, xm dmesg command did not become an error.
> 
> # xm dmesg xyz
>  __  __            _____  ___                     _        _     _      
>  \ \/ /___ _ __   |___ / / _ \    _   _ _ __  ___| |_ __ _| |__ | | ___ 
>   \  // _ \ '_ \    |_ \| | | |__| | | | '_ \/ __| __/ _` | '_ \| |/ _ \
>   /  \  __/ | | |  ___) | |_| |__| |_| | | | \__ \ || (_| | |_) | |  __/
>  /_/\_\___|_| |_| |____(_)___/    \__,_|_| |_|___/\__\__,_|_.__/|_|\___|
>                                                                         
>  http://www.cl.cam.ac.uk/netos/xen
>  University of Cambridge Computer Laboratory
> 
>  Xen version 3.0-unstable (root@) () Tue Oct 31 11:06:09 JST 2006
>  Latest ChangeSet: Mon Oct 30 17:35:11 2006 +0000 12033:b21246720fde
> 
> (XEN) Command line: /xen-3.0-unstable.gz
> (XEN) Physical RAM map:
> <snip>
> 
> 
> This patch adds a checking of wrong parameter into xm dmesg command.
> If wrong parameter is given, xm dmesg command shows the following 
> error messages.
> 
> # xm dmesg xyz
> Error: No parameter required
> Usage: xm dmesg [-c|--clear]
> 
> Read and/or clear Xend's message buffer.
>   -c, --clear                    Clear dmesg buffer 
> 
> 
> Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>

Applied, thank you.

Ewan.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel