WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH 0/6] printk log level and print rate.

To: Steven Rostedt <srostedt@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH 0/6] printk log level and print rate.
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Fri, 27 Oct 2006 08:59:18 +0100
Delivery-date: Fri, 27 Oct 2006 01:11:04 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <45417AB9.3030709@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acb5nc2HDA6OF2WREduHzQANk04WTA==
Thread-topic: [PATCH 0/6] printk log level and print rate.
User-agent: Microsoft-Entourage/11.2.5.060620
On 27/10/06 4:19 am, "Steven Rostedt" <srostedt@xxxxxxxxxx> wrote:

> The following is a rewrite of the printk log levels (plus the added
> print rate limit) as for Keir's suggestions.
> 
> This touches a lot so please test.

Two comments so far:

1. The rate-limiting code cannot rely on 'jiffies'. It's not required to
provide that variable in Xen (powerpc doesn't). Use NOW() and divide it down
(it returns a 64-bit nanoseconds value).

2. oops_in_progress is a bit cheesy. The user should be able to silence all
guest logging if they want. Let's remove it from the first cut of these
patches.

But basically it looks good. Please re-send all the patches after your next
round of fixups and I'll probably apply them at that point.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>