WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[PATCH] Re: [Xen-devel] [REQEST] about xentop -b

To: Atsushi SAKAI <sakaia@xxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [PATCH] Re: [Xen-devel] [REQEST] about xentop -b
From: Tony Breeds <tony@xxxxxxxxxxxxxxxxxx>
Date: Wed, 25 Oct 2006 14:17:11 +1000
Delivery-date: Tue, 24 Oct 2006 21:17:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20061025041004.GB27551@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Mail-followup-to: Atsushi SAKAI <sakaia@xxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
References: <200610250315.k9P3Fj7r002187@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <20061025041004.GB27551@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Wed, Oct 25, 2006 at 02:10:04PM +1000, Tony Breeds wrote:
 
> Looking at the current tip the problem is fixed.  I suggest you update
> your sources to the current release.
> or try the patch at:
> http://xenbits.xensource.com/xen-unstable.hg?cs=85b092b4567d

Actually there is a mistake in usage()

From: Tony Breeds <tony@xxxxxxxxxxxxxxxxxx>

[TOOLS][XENTOP] Update usage and manpage to include vbd options.

Also a couple of whitespace fixes.

Signed-off-by: Tony Breeds <tony@xxxxxxxxxxxxxxxxxx>

---
 xentop.1 |    3 +++
 xentop.c |    6 +++---
 2 files changed, 6 insertions(+), 3 deletions(-)
diff -r a661566745ae tools/xenstat/xentop/xentop.1
--- a/tools/xenstat/xentop/xentop.1     Tue Oct 24 16:46:02 2006 +0100
+++ b/tools/xenstat/xentop/xentop.1     Wed Oct 25 14:14:08 2006 +1000
@@ -47,6 +47,9 @@ seconds between updates (default 3)
 \fB\-n\fR, \fB\-\-networks\fR
 output network information
 .TP
+\fB\-x\fR, \fB\-\-vbds\fR
+output vbd block device data
+.TP
 \fB\-r\fR, \fB\-\-repeat\-header\fR
 repeat table header before each domain
 .TP
diff -r a661566745ae tools/xenstat/xentop/xentop.c
--- a/tools/xenstat/xentop/xentop.c     Tue Oct 24 16:46:02 2006 +0100
+++ b/tools/xenstat/xentop/xentop.c     Wed Oct 25 14:12:50 2006 +1000
@@ -204,7 +204,7 @@ static void usage(const char *program)
               "-V, --version        output version information and exit\n"
               "-d, --delay=SECONDS  seconds between updates (default 3)\n"
               "-n, --networks       output vif network data\n"
-              "-b, --vbds           output vbd block device data\n"
+              "-x, --vbds           output vbd block device data\n"
               "-r, --repeat-header  repeat table header before each domain\n"
               "-v, --vcpus          output vcpu data\n"
               "-b, --batch          output in batch mode, no user input 
accepted\n"
@@ -976,7 +976,7 @@ int main(int argc, char **argv)
                { "help",          no_argument,       NULL, 'h' },
                { "version",       no_argument,       NULL, 'V' },
                { "networks",      no_argument,       NULL, 'n' },
-               { "vbds",          no_argument,       NULL, 'x' },
+               { "vbds",          no_argument,       NULL, 'x' },
                { "repeat-header", no_argument,       NULL, 'r' },
                { "vcpus",         no_argument,       NULL, 'v' },
                { "delay",         required_argument, NULL, 'd' },
@@ -1065,7 +1065,7 @@ int main(int argc, char **argv)
                                        break;
                        } while (1);
        }
-
+
        /* Cleanup occurs in cleanup(), so no work to do here. */
 
        return 0;



Yours Tony

   linux.conf.au       http://linux.conf.au/ || http://lca2007.linux.org.au/
   Jan 15-20 2007      The Australian Linux Technical Conference!


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>