WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 6/6] xen,tools: add numa stat tool and hcalls

To: John Levon <levon@xxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 6/6] xen,tools: add numa stat tool and hcalls
From: Ryan Harper <ryanh@xxxxxxxxxx>
Date: Mon, 23 Oct 2006 16:11:23 -0500
Cc: Ryan Harper <ryanh@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 23 Oct 2006 14:12:01 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20061023204926.GC28984@xxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20061023180928.GK25762@xxxxxxxxxx> <20061023204926.GC28984@xxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.6+20040907i
* John Levon <levon@xxxxxxxxxxxxxxxxx> [2006-10-23 15:53]:
> On Mon, Oct 23, 2006 at 01:09:28PM -0500, Ryan Harper wrote:
> 
> > This patch adds a tool used to display how memory for each domain was
> > allocated (which nodes does a domain's memory reside within).  It also
> > dumps information about the Xen heap, including how many pages are in
> > each zone and node.
> 
> +        struct xen_domctl_availheap         availheap;
> +        struct xen_domctl_getdomnodestat    getdomnodestat;
>          uint8_t                             pad[128];
> 
> Don't you need to alter the pad to compensate?

AFAIK, I don't.  My understanding is that the pad[128] is the maximum
size for any member of the union.  Neither of the two added hypercalls
exceed 128.  

-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
(512) 838-9253   T/L: 678-9253
ryanh@xxxxxxxxxx

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>