WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH][Take 3-2][Resend] Sysfs Interface for balloon dr

To: Satoshi Uchida <s-uchida@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH][Take 3-2][Resend] Sysfs Interface for balloon driver
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Fri, 20 Oct 2006 20:17:03 +0100
Cc: 'Ian Pratt' <m+Ian.Pratt@xxxxxxxxxxxx>
Delivery-date: Fri, 20 Oct 2006 12:19:08 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <000001c6f432$fe1a0ca0$4c87380a@xxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acb0Mv3zPZ8H2WvbT5ufduNnL6MChgASVTo3
Thread-topic: [Xen-devel] [PATCH][Take 3-2][Resend] Sysfs Interface for balloon driver
User-agent: Microsoft-Entourage/11.2.5.060620
On 20/10/06 11:32 am, "Satoshi Uchida" <s-uchida@xxxxxxxxxxxxx> wrote:

> This mail is resend mail.
> But, the units is modified by result of discussion.
> The attached patch is final version.
> 
> Have anyone comments?

I don't remember the precise details of the debate about the sysfs names,
but <foo>_kibi_bytes isn't going to get checked in. I hate that stupid
naming scheme, especially where noone is likely to get confused between
whether 10^3 and 2^10 is meant. And the suffix is rather long too: it dwarfs
the interesting bit of the name.

Can I just 's/kibi_bytes/kb/g' when I check this in? Noone's going to get
confused that it's units of 10^3-bits or 10^3-bytes or 2^10-bits.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel