 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] removing event notification for HVM IRQ injection?
| To: | "Dong, Eddie" <eddie.dong@xxxxxxxxx>, <ssmith@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] removing event notification for HVM IRQ injection? |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Fri, 20 Oct 2006 19:09:08 +0100 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Fri, 20 Oct 2006 11:20:48 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <0E6FE5D295DE5B4B8D9070C26A2279873EEC87@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | Acb0J5WDC67RZQfzQNmF+ial5B6dhgAS0B3+ |
| Thread-topic: | [Xen-devel] removing event notification for HVM IRQ injection? |
| User-agent: | Microsoft-Entourage/11.2.5.060620 |
On 20/10/06 10:10 am, "Dong, Eddie" <eddie.dong@xxxxxxxxx> wrote:When looking at improving the HVM TPR acceleration, I noticed your previous patch (CSET:10974) replaced evtchn_set_pending in both hlt_timer_fn & vlapic_accept_irq with hvm_prod_vcpu. I am not sure for the purpose but at least one thing is missed after this patch: previous evtchn_set_pending may use physical IPI to interrupt target VP while hvm_prod_vcpu not. If the target VP is running, delivering guest IRQ ( both hlt_timer_fn & vlapic_accept_irq ) to a running VP have to use physical IPI to interrupt the execution to inject IRQ, without this the logic may be wrong. I suggest killing hvm_prod_vcpu() entirely and callers use vcpu_kick() instead. I think vcpu_kick() does exactly what you want. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] [PATCH 2/2 - resent], Steven Rostedt |
|---|---|
| Next by Date: | Re: [Xen-devel] [TOOLS][RFC] xc_get_pfn_list() and getmemlist.start_pfn, Keir Fraser |
| Previous by Thread: | [Xen-devel] removing event notification for HVM IRQ injection?, Dong, Eddie |
| Next by Thread: | [Xen-devel] Re: removing event notification for HVM IRQ injection?, Steven Smith |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
