WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [HVM][SVM][PATCH][2/2] Delay ExtInt Injection

To: "Woller, Thomas" <thomas.woller@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [HVM][SVM][PATCH][2/2] Delay ExtInt Injection
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Thu, 19 Oct 2006 23:10:29 +0100
Delivery-date: Thu, 19 Oct 2006 15:21:57 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <683860AD674C7348A0BF0DE3918482F603666BDB@xxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acbzymi4P2KtNndXRqyvD4zGkvhIlwAAPozJ
Thread-topic: [Xen-devel] [HVM][SVM][PATCH][2/2] Delay ExtInt Injection
User-agent: Microsoft-Entourage/11.2.5.060620
On 19/10/06 11:03 pm, "Woller, Thomas" <thomas.woller@xxxxxxx> wrote:

> Add flag to indicate that an exception event needs injecting, and to
> delay
> the ext interrupt injection.
> Remove unnecessary check of RFLAGS.IF for ExtInt injection.

Since EventInj is separate from V_IRQ, and both are supported simultaneously
(EventInj followed by V_IRQ, I hope!), why do you need to enforce mutual
exclusion favouring EventInj and delaying V_IRQ injection?

Removing the RFLAGS.IF check makes sense because the previous patch moves
the check later (and does dummy VIRQ injection instead of simply bailing).
But I don't see why the EventInj check gets added by this patch.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>