WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] Vmxassist build failure on gcc 3.3.5

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: RE: [Xen-devel] Vmxassist build failure on gcc 3.3.5
From: "Woller, Thomas" <thomas.woller@xxxxxxx>
Date: Thu, 19 Oct 2006 14:06:08 -0500
Delivery-date: Thu, 19 Oct 2006 12:34:39 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C15D86C6.2C95%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcbznSeBTn7r3870TrOkcPhwGhDWtgAEdkCBAACOytA=
Thread-topic: [Xen-devel] Vmxassist build failure on gcc 3.3.5
> I expect placing $DATA_SELECTOR in brackets $(DATA_SELECTOR) 
> will work. I expect the version of cpp is not able to pick 
> out a macro usage when it runs into adjacent punctuation.
> 
Yes. () works. Here is patch..
Thanks for the help
Tom

Signed-off-by: Tom Woller <thomas.woller@xxxxxxx>

diff -r 20522afb2615 tools/firmware/vmxassist/trap.S
--- a/tools/firmware/vmxassist/trap.S   Wed Oct 18 18:23:32 2006
+++ b/tools/firmware/vmxassist/trap.S   Thu Oct 19 13:50:53 2006
@@ -106,7 +106,7 @@
        pushl   %es
        pushal
 
-       movl    $DATA_SELECTOR, %eax    /* make sure these are sane */
+       movl    $(DATA_SELECTOR), %eax  /* make sure these are sane */
        movl    %eax, %ds
        movl    %eax, %es
        movl    %eax, %fs





_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel