[Xen-devel] Re: [PATCH][ACM] 2/3: make ACM architecture independent (Xen part)

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 18/10/06 16:57, "Stefan Berger" <stefanb@xxxxxxxxxx> wrote:

> This patch moves the multiboot-specific part of the ACM initialization
> into its own file. Any architecture that implements the multiboot
> specification should be able to reuse this function for booting a
> machine with an ACM policy.
> It also moves the x86-specific functions into an x86 include file.
> 
> Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxx>

Hmm... It's a single small function with a fairly nasty interface. I don't
think making it arch-independent is a good idea. I already shrunk the
function down a bit when applying Tristan's patch so it's not actually very
big.

My main issue is that it is intertwined with the variables that setup.c
maintains to track multiboot modules. It would be cleaner to make more of
setup.c arch-independent and carry the acm_multiboot function with it. All
the while the rest is inside arch/x86, I think acm_multiboot should stay
there too.

I did take your third patch, by the way (tools alignment change).

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel