WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] building blktap as a module

To: Gerd Hoffmann <kraxel@xxxxxxx>
Subject: Re: [Xen-devel] building blktap as a module
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Mon, 16 Oct 2006 13:56:54 +0100
Cc: Andrew Warfield <Andrew.Warfield@xxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Jan Beulich <jbeulich@xxxxxxxxxx>
Delivery-date: Mon, 16 Oct 2006 05:57:29 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <453370DB.8090902@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcbxIo39zJyo2l0VEduyIAAX8io7RQ==
Thread-topic: [Xen-devel] building blktap as a module
User-agent: Microsoft-Entourage/11.2.5.060620


On 16/10/06 12:45, "Gerd Hoffmann" <kraxel@xxxxxxx> wrote:

>>  1. The one in blktap_release() - why? Standard semantics is for mmap
>> regions to exist beyond the closing of the mapping device. Doesn't make much
>> sense to do that here, but then again not really any need to explicitly
>> disallow it (and add extra code to enforce).
> 
> The linux kernel does call the drivers release() method when the last
> reference is gone.  If you call close() with mappings still being
> active, then ->release() is _not_ called when you close the file handle
> but when the last mapping is unmapped.  Thus there is no point in trying
> to handle active mappings there ;)

I.e., they'll have been unmapped already? As you say, either way the zap is
not needed...

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>