WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Sleeping with spinlock held

To: Glauber de Oliveira Costa <gcosta@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Sleeping with spinlock held
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Mon, 09 Oct 2006 20:39:54 +0100
Delivery-date: Mon, 09 Oct 2006 12:50:56 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20061009193047.GA28540@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acbr2rGA7+0cl1fNEduJIgANk04WTA==
Thread-topic: [Xen-devel] [PATCH] Sleeping with spinlock held
User-agent: Microsoft-Entourage/11.2.5.060620
On 9/10/06 8:30 pm, "Glauber de Oliveira Costa" <gcosta@xxxxxxxxxx> wrote:

> In drivers/xen/blkfront/blkfront.c, flush_scheduled_work(), that might
> sleep, is being called with a spinlock held, thus triggering a BUG.
> I think it's safe to just poke it out from the locked region, as it
> seems to me we won't be receiving any more work at this time.
> 
> In case you agree, I'm attaching a simple patch that fix this.

Already fixed in xen-unstable, but thanks!

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>