WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] xm reboot/shutdown/sysrq to HVM domain

To: Tetsu Yamamoto <yamamoto.tetsu@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xm reboot/shutdown/sysrq to HVM domain
From: Steven Smith <sos22-xen@xxxxxxxxxxxxx>
Date: Fri, 6 Oct 2006 10:59:03 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, sos22@xxxxxxxxxxxxx
Delivery-date: Fri, 06 Oct 2006 02:59:40 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <4526005B.1020906@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4526005B.1020906@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
> This patch enhances 'xm reboot'/'xm shutdown' commands to
> reboot/shutdown guest Linux on HVM domain as gracefully as para-Linux.
> In addtion, sysrq key signal can be sent to HVM domain by 'xm sysrq'
> command.
Thanks, that's really useful.  I have a couple of comments about the
patch, though:

-- It looks like you had some problems with ctrl_alt_del(), and instead
   used kill_proc(cad_pid, SIGINT, 1).  What was the reason for this?   

-- You've introduced a lot of #ifdefs into reboot.c.  It might be
   easier to just split the file in two; did you look at this at all?

-- You set reboot_module from within a xenbus transaction.  I don't
   think that's necessary, since xenbus_writes are supposed to be
   atomic anyway.

-- Because of the way mkbuildtree works, you're going to create
   symlinks from unmodified-drivers to all of the files in
   linux-2.6-xen-sparse/drivers/core, rather than just to reboot.c.
   It's a trivial aesthetic issue, but it'd be nice not to create lots
   of useless symlinks.

Apart from that, it looks pretty reasonable.

Steven.

Attachment: signature.asc
Description: Digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>