Re: [Xen-devel] [patch] Fix 32bit xen-tools build.

[Gerd Hoffmann <kraxel@xxxxxxx>]

Keir Fraser wrote:
> The mbootpack change seems wrong. It's not installed on the target machine
> (it's a build-system tool) so it should actually be built with HOSTCFLAGS,
> not CFLAGS. Is that reasonable?

For the x86_32 on x86_64 it works as-is, because the 32bit binaries work
on 64bit too.  Looking at it strictly it is indeed  not fully correct
though, HOSTCCFLAGS should be used instead.  But some more tweaks are
needed then, you'll have to take care that the object files are compiled
with HOSTCC (and HOSTCFLAGS) too (they are not at the moment).

> Presumably the most important part of this patch is the change to LDFLAGS
> and ASFLAGS?

Yes, that makes most bits compile fine, except qemu-dm.

> I suppose any halfway modern version of binutils must support
> those flags (otherwise gcc -m32 wouldn't work)?

Yes, gcc passes -m32 through to the linker.

cheers,

  Gerd

-- 
Gerd Hoffmann <kraxel@xxxxxxx>
http://www.suse.de/~kraxel/julika-dora.jpeg

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel