Re: [Xen-devel] [PATCH 4/6] xen: export NUMA topology in physinfo hcall

[Tristan Gingold <Tristan.Gingold@xxxxxxxx>]

Le Vendredi 29 Septembre 2006 20:58, Ryan Harper a écrit :
> This patch modifies the physinfo hcall to export NUMA CPU and Memory
> topology information.  The new physinfo hcall is integrated into libxc
> and xend (xm info specifically).  Included in this patch is a minor
> tweak to xm-test's xm info testcase.  The new fields in xm info are:
>
> nr_nodes               : 4
> mem_chunks             : node0:0x0000000000000000-0x0000000190000000
>                          node1:0x0000000190000000-0x0000000300000000
>                          node2:0x0000000300000000-0x0000000470000000
>                          node3:0x0000000470000000-0x0000000640000000
> node_to_cpu            : node0:0-7
>                          node1:8-15
>                          node2:16-23
>                          node3:24-31
Hi,

I have successfully applied this patch on xen-ia64-unstable.  It requires a 
small patch to fix issues.
I have tested it on a 4 node, 24 cpus system.

I have two suggestions for physinfo hcall:
* We (Bull) already sell machines with more than 64 cpus (up to 128).  
Unfortuantly the physinfo interface works with at most 64 cpus.  May I 
suggest to replace the node_cpu_to maps with a cpu_to_node map ?

* On ia64 memory can be sparsly populated.  There is no real relation between 
number of nodes and number of memory chunks.  May I suggest to add a new 
field (nr_mem_chunks) in physinfo ?  It should be a read/written field: it 
should return the number of mem chunks at ouput (which can be greather than 
the input value if the buffer was too small).

Comments ?

Tristan.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel