WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [Xen-ia64-devel] [PATCH] make MAX_SKBUFF_ORDER page

To: Tristan Gingold <Tristan.Gingold@xxxxxxxx>, Isaku Yamahata <yamahata@xxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [Xen-ia64-devel] [PATCH] make MAX_SKBUFF_ORDER page size independent
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 03 Oct 2006 07:59:35 +0100
Cc: xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 03 Oct 2006 00:10:28 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200610030843.35005.Tristan.Gingold@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcbmuXv6ukljJFKsEduXeAANk04WTA==
Thread-topic: [Xen-devel] Re: [Xen-ia64-devel] [PATCH] make MAX_SKBUFF_ORDER page size independent
User-agent: Microsoft-Entourage/11.2.5.060620
On 3/10/06 7:43 am, "Tristan Gingold" <Tristan.Gingold@xxxxxxxx> wrote:

> Le Mardi 03 Octobre 2006 07:06, Isaku Yamahata a écrit :
>> make MAX_SKBUFF_ORDER page size independent.
>> Presumably the original value 4 comes from 64KB = (4KB << 4) which is
>> ip packet maximum size.
>> However page size is not always 4KB. e.g. IA64 default page size is 16KB.
> I suppose it fixes the fedora bug ?
> 
> I wonder if this patch works when pagesize is 64KB ?  Maybe force 1 as the
> minimum value ?

We want to move to the copying receive path as default asap by the way, you
might want to check that it works with ia64 (boot a domU with extra Linux
cmdline option "xennet.rx_copy" and check you get a boot message saying that
a net device eth0 has been created with copying receive path).

Also since our network interfaces now support scatter-gather (thanks to
Herbert Xu) I expect to get rid of our special skbuff allocators, at least
for oridnary alloc_skb and dev_alloc_skb calls. This should happen early in
the 3.0.4 development cycle.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel